Replace class constraint with AnyObject
#1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yhkaplan: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
LGTM! Thanks for the clean up! |
|
With Xcode 12.5 in RC now, it would be nice to get a version released with this warning fixed. Thanks! |
|
Hey - I'm working on some tests for some web socket stuff that was merged earlier today before I do a release but will try to get this out early next week. |
Great, thanks! |
|
Guh, apple, why you gotta release Xcode on a Monday? will cut a release tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty insignificant, but the recommended practice in Swift now is to use AnyObject instead of class, and recently there have been motions toward a new reference type (
actor) that theclassnaming makes a little unclear, while AnyObject is more of a generic and all-encompassing term for reference types. Also, the class constraint typealias may be removed in future versions of Swift.ref: https://github.com/apple/swift-evolution/blob/master/proposals/0156-subclass-existentials.md#class-and-anyobject