Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.12.2 #367

Merged
merged 4 commits into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/ci-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,24 @@ jobs:
run: |
git diff --exit-code

verify-cli-binary-archive:
runs-on: macos-13
needs: [changes]
if: ${{ needs.changes.outputs.codegen == 'true' }}
timeout-minutes: 5
name: Verify CLI Binary Archive - macOS
steps:
- name: Checkout Repo
uses: actions/checkout@v3
- name: Extract CLI Binary
shell: bash
working-directory: apollo-ios/CLI
run: tar -xf apollo-ios-cli.tar.gz apollo-ios-cli
- name: Verify Version
shell: bash
working-directory: apollo-ios/scripts
run: ./cli-version-check.sh

run-cocoapods-integration-tests:
runs-on: macos-13
timeout-minutes: 20
Expand Down
2 changes: 1 addition & 1 deletion apollo-ios-codegen/Sources/CodegenCLI/Constants.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Foundation

public enum Constants {
public static let CLIVersion: String = "1.12.1"
public static let CLIVersion: String = "1.12.2"
static let defaultFilePath: String = "./apollo-codegen-config.json"
}
5 changes: 5 additions & 0 deletions apollo-ios/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## v1.12.2

### Fixed
- **Rebuilt the CLI binary with the correct version number:** The CLI binary included in the `1.12.1` package was built with an incorrect version number causing a version mismatch when attempting to execute code generation.

## v1.12.1

### Fixed
Expand Down
Binary file modified apollo-ios/CLI/apollo-ios-cli.tar.gz
Binary file not shown.
2 changes: 1 addition & 1 deletion apollo-ios/Sources/Apollo/Constants.swift
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Foundation

public enum Constants {
public static let ApolloVersion: String = "1.12.1"
public static let ApolloVersion: String = "1.12.2"
}
18 changes: 18 additions & 0 deletions apollo-ios/scripts/cli-version-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/bin/bash

directory=$(dirname "$0")
projectDir="$directory/../CLI"

APOLLO_VERSION=$(sh "$directory/get-version.sh")
FILE_PATH="$projectDir/apollo-ios-cli.tar.gz"
tar -xf "$FILE_PATH"
CLI_VERSION=$(./apollo-ios-cli --version)

echo "Comparing Apollo version $APOLLO_VERSION with CLI version $CLI_VERSION"

if [ "$APOLLO_VERSION" = "$CLI_VERSION" ]; then
echo "Success - matched!"
else
echo "Failed - mismatch!"
exit 1
fi
Loading