-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.12.2
#367
Merged
Merged
release: 1.12.2
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
BobaFetters
approved these changes
May 23, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
May 23, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
May 23, 2024
BobaFetters
pushed a commit
that referenced
this pull request
May 23, 2024
99dfbdb8 release: (#367) git-subtree-dir: apollo-ios git-subtree-split: 99dfbdb869dbba16bd09e086b2b669bfcab811ec
BobaFetters
pushed a commit
that referenced
this pull request
May 23, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 7518a89 git-subtree-split: 99dfbdb869dbba16bd09e086b2b669bfcab811ec
BobaFetters
pushed a commit
that referenced
this pull request
May 23, 2024
6e7bd0dd release: (#367) git-subtree-dir: apollo-ios-codegen git-subtree-split: 6e7bd0dd3f8620685b2c510dafeecef8e74ef8d1
BobaFetters
pushed a commit
that referenced
this pull request
May 23, 2024
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 5eeda94 git-subtree-split: 6e7bd0dd3f8620685b2c510dafeecef8e74ef8d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-ios#3386.
This prepares for release
1.12.2
and also adds a new CI job that verifies the CLI binary archive by ensuring it can be extracted, executed and matches the accompanying Apollo iOS package.I also verified the new CI job works as expected by cherry-picking the commit on top of the
1.12.1
release branch which should fail due to the version mismatch. You can see the result of that in #368.Diff
See diff since last version.
Things to do in this PR
set-version.sh
script.CHANGELOG.md
with all relevant changes since the prior version. Please include PR numbers and mention contributors for external PR submissions.SwiftScripts
folder using the commandswift run DocumentationGenerator
to re-generate the API reference documentation from source for all included libraries. Make sure you are on HEAD of the parent branch otherwise the documentation generator will not catch all changes, rebase this PR if needed.make archive-cli-to-apollo-package
to attach cli to apollo-ios packageThings to do as part of releasing
major.minor.patch
to GitHub.CHANGELOG.md
contents.make archive-cli-for-release
command which builds both Intel and ARM architectures, and creates the tar archive for you.pod trunk push Apollo.podspec
andpod trunk push ApolloTestSupport.podspec
to publish to CocoaPods. You will need write permissions for this, please contact one of the maintainers if you need access to do this.apollo-ios-xcframework