Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 1.12.2 #367

Merged
merged 4 commits into from
May 23, 2024
Merged

release: 1.12.2 #367

merged 4 commits into from
May 23, 2024

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented May 23, 2024

Closes apollographql/apollo-ios#3386.

This prepares for release 1.12.2 and also adds a new CI job that verifies the CLI binary archive by ensuring it can be extracted, executed and matches the accompanying Apollo iOS package.

I also verified the new CI job works as expected by cherry-picking the commit on top of the 1.12.1 release branch which should fail due to the version mismatch. You can see the result of that in #368.

Diff

See diff since last version.

Things to do in this PR

  • Update the version constants using the set-version.sh script.
  • Update CHANGELOG.md with all relevant changes since the prior version. Please include PR numbers and mention contributors for external PR submissions.
  • Run the Documentation Generator from the internal SwiftScripts folder using the command swift run DocumentationGenerator to re-generate the API reference documentation from source for all included libraries. Make sure you are on HEAD of the parent branch otherwise the documentation generator will not catch all changes, rebase this PR if needed.
  • Run make archive-cli-to-apollo-package to attach cli to apollo-ios package

Things to do as part of releasing

  • Add tag of format major.minor.patch to GitHub.
  • Create a release on GitHub with the new tag, using the latest CHANGELOG.md contents.
  • Attach CLI binary to the GitHub release. Use the make archive-cli-for-release command which builds both Intel and ARM architectures, and creates the tar archive for you.
  • Run pod trunk push Apollo.podspec and pod trunk push ApolloTestSupport.podspec to publish to CocoaPods. You will need write permissions for this, please contact one of the maintainers if you need access to do this.
  • Run "Release New Version" workflow in apollo-ios-xcframework

Copy link

netlify bot commented May 23, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 8551336
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/664ece637c74b9000849fc6e

Copy link

netlify bot commented May 23, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit 8551336
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/664ece63259cc30008643b91

@calvincestari calvincestari merged commit 5301099 into main May 23, 2024
26 checks passed
@calvincestari calvincestari deleted the release/1.12.2 branch May 23, 2024 20:00
BobaFetters pushed a commit that referenced this pull request May 23, 2024
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request May 23, 2024
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request May 23, 2024
BobaFetters pushed a commit that referenced this pull request May 23, 2024
99dfbdb8 release:  (#367)

git-subtree-dir: apollo-ios
git-subtree-split: 99dfbdb869dbba16bd09e086b2b669bfcab811ec
BobaFetters pushed a commit that referenced this pull request May 23, 2024
git-subtree-dir: apollo-ios
git-subtree-mainline: 7518a89
git-subtree-split: 99dfbdb869dbba16bd09e086b2b669bfcab811ec
BobaFetters pushed a commit that referenced this pull request May 23, 2024
6e7bd0dd release:  (#367)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 6e7bd0dd3f8620685b2c510dafeecef8e74ef8d1
BobaFetters pushed a commit that referenced this pull request May 23, 2024
git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: 5eeda94
git-subtree-split: 6e7bd0dd3f8620685b2c510dafeecef8e74ef8d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version mismatch between package and CLI
2 participants