Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: calculate loading state from networkStatus #831

Closed
helfer opened this issue Oct 24, 2016 · 1 comment
Closed

Refactor: calculate loading state from networkStatus #831

helfer opened this issue Oct 24, 2016 · 1 comment
Assignees
@calebmer

Comments

@helfer
Copy link
Contributor

helfer commented Oct 24, 2016

loading is still used in a lot of places, but it could be entirely replaced with checks on networkStatus.
@stubailo stubailo mentioned this issue Jan 6, 2017
Closed
@calebmer calebmer self-assigned this Jan 19, 2017
@calebmer
Copy link
Contributor

We want to make sure this change fixes the following issues:

Let me know if there are more that we should look at when testing this change.

@calebmer calebmer mentioned this issue Jan 19, 2017
Merged
4 tasks
@helfer helfer closed this as completed Mar 29, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@calebmer calebmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helfer @calebmer