[Runtime] deprecate the "builder" methods on ApolloCall and add them on the Builder instead
#2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
approved these changes
Jul 8, 2020
sav007
approved these changes
Jul 9, 2020
martinbonnin
force-pushed
the
feature-2430/improve-api
branch
from
f7b8638
to
61b95bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2430
The
ApolloCall.responseFetcher(),ApolloCall.cacheHeaders()methods and others are confusing because they are acting like "builder" methods and return a new instance ofApolloCallbut they're actually not part of theBuilder. It's very easy to miss the return value if not cautious.Deprecate them and add them in the
Builderwhere they belong.