-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow owner to select the API they are viewing the analytics for #999
Comments
Is there any case that user wants to see multiple APIs? for comparison purpose? |
See Brylie's support request and Nick's answer to it: NREL/api-umbrella#252 |
@frenchbread will you be taking this task forward? |
Yes. |
This is number one priority. High priority and urgent. It blocks several other tasks. |
Got it. |
Currently the URl for making requests looks like |
Generally, an API owner will need to see the API Name. However you link the API Name to the filter is up to you. E.g. if API ID is easiest, go with it, but make sure the end-user has an intuitive way to filter the dashboard. |
Actually now, when sending custom requests (with api backend id in the URL) there are only 404 responses. I'm not sure how did we manage to add API Id to the request URL but it won't work that way I thing because now API Id is represented in URL as a separate page - not as a parameter. |
One more question: If there is no API selected, should we show anything?
|
I like the second option, showing analytics for multiple/all API Backends. We can also consider having a multi-select box, so that an Administrator or API Owner can select multiple API Backends. I have added Bootstrap Select to a project recently, and it is easy to use. |
One short-term goal here is to try and share most of the Dashboard code/functionality between Administrators and API Owners. |
Cool. Yea, that is possible. What about using API Id in the URL then?
|
If API ID works, go for it. We just need to show the end-user the API Name, so they understand what they are seeing. |
It works but response is 404, because API ID is provided not as a query parameter |
As per the discussion with Nick (@GUI) and your observations, using the the API ID won't work for analytics queries. It was suggested that we filter by the 'path' or 'frontend_prefix'. How are you filtering the API? |
The UI looks good by the way. |
I have a suggestion. Can we only show the 3XX, 4XX and 5XX requests in the HTTP status code chart with bigger bars. Currently they look small. Also I was thinking that is it necessary to keep the 2XX status bar there? because we are already will be showing success rate if API calls in overview information. SO the HTTP Status code chart should focus on issues other than 2XX. |
One challenge about making the 3, 4, and 5xx bars larger with respect to the 2xx bars, is that there are sometimes 'orders of magnitude' fewer requests with 3xx, 4xx, or 5xx codes. E.g. there may be:
This type of situation is where a logarithmic scale becomes useful. @frenchbread can we configure the HTTP Status Codes chart to use a logarithmic scale (d3.js) for the request counts axis? |
I'm filtering charts by API Id now. It works, but I can switch to |
I think we can configure the HTTP Status Codes chart to use a logarithmic scale but is separate issue. |
@Nazarah would you please open an enhancement for the HTTP Status Codes chart? I can add details about the logarithmic axis, if you will add your initial reasoning. |
@frenchbread where are you getting the API ID from? If we cannot query Elastic by API ID, then perhaps |
@brylie If you look at the screenshots above, in the table there is a row with It won't be more difficult to use |
OK, so does the API ID in the screenshot ( |
Yes, and that's why when I send sample requests they return 404. |
OK, just use the |
Updated filtering to use front-end prefix instead of API id. |
Cool beans. Let me know when this is ready for review. |
OK, I'm now going to add filtering for "default selection" - combined analytics for all APIs owned by a user. |
@frenchbread good idea 😄 |
The main user of the dashboard is an API owner who checks the dashboard for performance and to get insight into API usage. When API owner is viewing the dashboard, they should also be able to define or select an API they see analytics for (from their APIs)
User story
Design
Definition of done
Resources
The text was updated successfully, but these errors were encountered: