Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry server: move to new repo? #1225

Open
timburks opened this issue Sep 15, 2023 · 0 comments
Open

Registry server: move to new repo? #1225

timburks opened this issue Sep 15, 2023 · 0 comments

Comments

@timburks
Copy link
Contributor

timburks commented Sep 15, 2023

Currently this repo builds two tools: the registry CLI and the registry-server. To allow these to be separately versioned and to minimize their dependencies, let's consider splitting this into two repos. Two possible options are:

  1. move the registry tool to a new repo (registry-tool?) and most of the CLI support code in pkg would go with it.
  2. move the registry-server to a new repo (registry-server?)

In either case, we should maintain history by making the copy a fork of the main repo and then pruning the two repos to be nonoverlapping.

Option 2 (create a registry-server repo) seems less disruptive to downstream tools that import the pkg directory. But it's not immediately clear where the protos should reside. I think we want to avoid having registry-server depend on registry, because it would inherit the registry dependencies, so this suggests that the protos and generated proto and grpc support code should be in the new registry-server repo. But the gapic and all other client-related code would remain in registry and reference their dependencies from registry-server. Note that there's also proto-based generated code in pkg/application, but since none of these types are used by the server, this code can probably remain in the registry repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

1 participant