fix: Ensure plain text response is only used for strings #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out when expected errors occur (eg: those defined via
potential_error
in an endpoint) they are still handled via the responserack_triplet
method. This means the error hash was being treated as plain text instead of JSON if the endpoint specified a plain text responseThis PR fixes that by only rendering a plain text response if the type is plain text and the response body is a string