Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc_client_nginx_module version in build script for apisix-base #325

Open
Revolyssup opened this issue Aug 9, 2023 · 4 comments
Assignees

Comments

@Revolyssup
Copy link
Collaborator

Current the latest version of grpc-client-nginx-module is 0.4.2, as a new bug fix was made another release will be made with version 0.4.3.

@yuluo-yx
Copy link

yuluo-yx commented Aug 9, 2023

Please assign it to me and I will get it done.

@Revolyssup
Copy link
Collaborator Author

I have created a PR for this #326
After this is merged, we can go ahead and make a release of apisix-base

@yuluo-yx
Copy link

I have created a PR for this #326 After this is merged, we can go ahead and make a release of apisix-base

As you know so far, I'm an intern and I'm new to the project.
What I am wondering is, is it only necessary to modify this line of code to solve this issue? Don't need to do other stuff? (My current understanding is that this project provides construction services for apisix. I don’t know if this understanding is correct?)

@Revolyssup
Copy link
Collaborator Author

I have created a PR for this #326 After this is merged, we can go ahead and make a release of apisix-base

As you know so far, I'm an intern and I'm new to the project. What I am wondering is, is it only necessary to modify this line of code to solve this issue? Don't need to do other stuff? (My current understanding is that this project provides construction services for apisix. I don’t know if this understanding is correct?)

After this change, when a release is made and this script runs. This new version of grpc_client_nginx_module will be packaged inside new apisix-base release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants