Proposal CastVote unit should be "shares" instead of "tokens"

[dcroote]

Steps to reproduce

Visit a proposal page, for example CORE TECHNICAL TEAM PROPOSAL, MARCH–MAY 2023.

Expected behavior

The "Supported with" or "Voted against with" value should report the correct number of shares that voted.

Current behavior

The value is currently reported as "tokens" (red arrow in screenshot). Note that above the events table, "shares" is used correctly (green underlines in screenshot).

Screenshots (if applicable)

Environment

Any

Potential consequences

The user may be confused as tokens are not the same as shares. This is described in the docs under the Earning Rewards section:

Remember that when you stake, you receive non-transferable pool shares equal to the current total number of issued shares divided by the total number of tokens staked. Since the reward adds additional tokens to the pool, the "price" for one share will not always be one token.