Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only store fresh signed data #79

Closed
Siegrift opened this issue Nov 7, 2023 · 4 comments · Fixed by #100
Closed

Only store fresh signed data #79

Siegrift opened this issue Nov 7, 2023 · 4 comments · Fixed by #100
Assignees

Comments

@Siegrift
Copy link
Collaborator

Siegrift commented Nov 7, 2023

Currently, we do not store active dAPIs in state which means that we need to store the signed data for every beacon even if there are only a few active beacons among the active dAPIs.

Another side effect of this is that once we fetch a data for a beacon, we persist it forever.

@aquarat
Copy link
Collaborator

aquarat commented Nov 13, 2023

We store dapiNames received from the contract in the state, so the signed data fetch loop can just filter incoming samples by active dAPIs. I'll do this.

@aquarat aquarat self-assigned this Nov 13, 2023
@Siegrift
Copy link
Collaborator Author

I remember we discussed the first part (only saving data for active dAPIs) in the spec and @bbenligiray wasn't sold on this.

Another side effect of this is that once we fetch a data for a beacon, we persist it forever.

We didn't discuss this which feels to me is a reason of itself to implement this. We should discuss this at the weekly call.

I'll do this.

Yeah, go ahead.

@aquarat aquarat changed the title Consider keeping signed data only for active dAPIs Only retain signed data for active dAPIs Nov 14, 2023
@aquarat
Copy link
Collaborator

aquarat commented Nov 14, 2023

It was decided in the call to (1) not store active dapis in the state and (2) purge the signed data store by timestamp (> 24 hours) and not by active dapis.

@Siegrift
Copy link
Collaborator Author

Can you change the issue title as well?

@aquarat aquarat changed the title Only retain signed data for active dAPIs Only store signed data for active dapis Nov 15, 2023
@aquarat aquarat changed the title Only store signed data for active dapis Only store fresh signed data Nov 16, 2023
@aquarat aquarat linked a pull request Nov 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants