-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only store fresh signed data #79
Comments
We store dapiNames received from the contract in the state, so the signed data fetch loop can just filter incoming samples by active dAPIs. I'll do this. |
I remember we discussed the first part (only saving data for active dAPIs) in the spec and @bbenligiray wasn't sold on this.
We didn't discuss this which feels to me is a reason of itself to implement this. We should discuss this at the weekly call.
Yeah, go ahead. |
It was decided in the call to (1) not store active dapis in the state and (2) purge the signed data store by timestamp (> 24 hours) and not by active dapis. |
Can you change the issue title as well? |
Currently, we do not store active dAPIs in state which means that we need to store the signed data for every beacon even if there are only a few active beacons among the active dAPIs.
Another side effect of this is that once we fetch a data for a beacon, we persist it forever.
The text was updated successfully, but these errors were encountered: