-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uuid
as coordinator ID
#280
Comments
I don't see the case you're describing. One argument for using timestamp was ordering - you can easily see what coordinator loop started first. The problem with timestamp is that it's hard to visually distinguish it from other timestamp. That said, I see no disadvantage in using UUID and logging a timestamp at the start of the coordinator loop.
I am not sure what you mean - the coordinator ID is different for each chain/provider combination. |
Decided to stick with timestamp here |
Changed decision in #292 (comment) |
Current timestamp is utilized as coordinator ID for both
dataFetcherCoordinatorId
andupdateFeedsCoordinatorId
. However timestamp isn't good choice to discriminate invoked functions especially there is bug related to race conditioning. That being said, because assigning coordinator ID is being done before staggering, coordinator IDs for same data feed from different RPC providers results in same.The text was updated successfully, but these errors were encountered: