Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update individual beacons directly #260

Closed
Siegrift opened this issue Apr 18, 2024 · 3 comments · Fixed by #266
Closed

Update individual beacons directly #260

Siegrift opened this issue Apr 18, 2024 · 3 comments · Fixed by #266
Assignees

Comments

@Siegrift
Copy link
Collaborator

Do not use tryMulticall. See: https://api3workspace.slack.com/archives/C05TQPT7PNJ/p1713434599386719

@bbenligiray
Copy link
Member

I was busy with the migration outage while writing to that thread. There are two options with the gas limit, either don't estimate it at all and omit it in the transaction (so that ethers does it under the hood), or do it explicitly. When we do it explicitly, we can just estimate it and use it exactly, we wouldn't need the multicall-tryMulticall trick or the 1.1 multiplier.

@Siegrift
Copy link
Collaborator Author

There are two options with the gas limit, either don't estimate it at all and omit it in the transaction (so that ethers does it under the hood), or do it explicitly.

Yes, that's basically what I was asking.

When we do it explicitly, we can just estimate it and use it exactly, we wouldn't need the multicall-tryMulticall trick or the 1.1 multiplier.

So that's basically what you're saying in the thread. I am not sure what you mean by your comment. Is it just for additional clarity?

@bbenligiray
Copy link
Member

Yes, just saying the same stuff but more explicitly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants