Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @api3/eslint-plugin-commons for eslint #2013

Open
dcroote opened this issue Aug 10, 2024 · 1 comment
Open

Use @api3/eslint-plugin-commons for eslint #2013

dcroote opened this issue Aug 10, 2024 · 1 comment

Comments

@dcroote
Copy link
Contributor

dcroote commented Aug 10, 2024

A number of new rules require parserServices to be generated which results in the error:

You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser

Currently it isn't specified:

airnode/.eslintrc.js

Lines 9 to 12 in c43d981

parserOptions: {
ecmaVersion: 11,
sourceType: 'module',
},

Specifying this, however, isn't as easy as other repos given this monorepo structure and, I believe, how the packages' tsconfig.json files use references, potentially confusing ESLint on how to find the files.

Disabling these few rules allows it to run, but with quite a number of errors:

✖ 2921 problems (2921 errors, 0 warnings)
399 errors and 0 warnings potentially fixable with the `--fix` option.
@Siegrift
Copy link
Contributor

Yeah, I think for Airnode we should disable many of the non-fixable rules just to make the migration simpler. These can always be re-enabled later as separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants