Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot request team for release PR review #1907

Closed
dcroote opened this issue Oct 30, 2023 · 0 comments · Fixed by #1908
Closed

Cannot request team for release PR review #1907

dcroote opened this issue Oct 30, 2023 · 0 comments · Fixed by #1908

Comments

@dcroote
Copy link
Contributor

dcroote commented Oct 30, 2023

I encountered the following when running yarn docker:scripts:npm:pull-request --release-version 0.13.0 --head-branch release-v0.13.0 --base-branch master as part of the Airnode release process (#1906)

/webpack:/api3/docker/scripts/github.ts:106
    throw new Error(`Can't request a review for GitHub PR ${pullRequestNumber}: ${goRequestReview.error}`);
^
Error: Can't request a review for GitHub PR 1906: HttpError: Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the api3dao/airnode repository.
    at Object.requestPullRequestReview (/webpack:/api3/docker/scripts/github.ts:106:1)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Which comes from:

export const requestPullRequestReview = async (pullRequestNumber: number) => {
const octokit = initializeOctokit();
const goRequestReview = await go(() =>
octokit.request(`POST /repos/${OWNER}/${REPOSITORY}/pulls/${pullRequestNumber}/requested_reviewers`, {
owner: OWNER,
repo: REPOSITORY,
pull_number: pullRequestNumber,
team_reviewers: [TEAM],
})
);
if (!goRequestReview.success) {
throw new Error(`Can't request a review for GitHub PR ${pullRequestNumber}: ${goRequestReview.error}`);
}
};

While this is slightly strange as there is a single team within the script and it hasn't changed in 11 months:

const TEAM = 'airnode';

I believe this has to do with a reorganization / renaming of the repo "Collaborators" teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant