Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky CI workflow: Verify Protocol Deployments #1874

Closed
dcroote opened this issue Sep 6, 2023 · 0 comments · Fixed by #1875
Closed

Flaky CI workflow: Verify Protocol Deployments #1874

dcroote opened this issue Sep 6, 2023 · 0 comments · Fixed by #1875
Assignees
Milestone

Comments

@dcroote
Copy link
Contributor

dcroote commented Sep 6, 2023

The "Verify Protocol Deployments" CI workflow runs whenever an airnode-protocol file changes:

on:
pull_request:
branches:
- master
paths:
- 'packages/airnode-protocol/**'
types: [opened, synchronize, reopened]

Unfortunately, this means it is triggered for dependency PRs that modify packages/airnode-protocol/package.json e.g. this one. It shouldn't be a problem, but some chains in particular are very flaky, resulting in the workflow failing more often than not, it has intermittently failed and passed, and rerunning just this step in Actions will sometimes work, but usually not. Sometimes it's one chain e.g. gnosis, gnosis-testnet, or polygon-testnet, other times is a combination of several.

I think we should at least exclude packages/airnode-protocol/package.json from the paths that trigger the run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant