Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airnode forwards blockchain provider error messages as is #1750

Open
bbenligiray opened this issue Apr 24, 2023 · 1 comment
Open

Airnode forwards blockchain provider error messages as is #1750

bbenligiray opened this issue Apr 24, 2023 · 1 comment
Labels
bug Something needs to be fixed

Comments

@bbenligiray
Copy link
Member

Refer to https://api3workspace.slack.com/archives/C02AYRX8D89/p1681907159870799

Run yarn && yarn main on https://github.com/bbenligiray/fulfillment-analysis and you will see fail() being called with errorMessages such as call revert exception; VM Exception while processing transaction: reverted with reason string "In... This is because the static test call before the fulfillment errored. There are two problems with this:

I think there are two options:

  1. Use a generic errorMessage instead
  2. Use a generic errorMesssage, but bubble up the revert string when possible

I did make use of the first two characters of the revert message while debugging, so I'm not 100% on 1. That being said, the revert string is embedded in the API response and the format of that likely depends on the blockchain provider implementation, so I'm not sure if this can be done in a generalized way. If 2 seems not doable, 1 is still the way to go because in most cases two characters won't be enough so we won't be losing too much.

@bbenligiray
Copy link
Member Author

Probably related #1651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants