Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing redeployment when the HTTP gatewayes become disabled #1450

Closed
amarthadan opened this issue Sep 14, 2022 · 1 comment · Fixed by #1456
Closed

Fix failing redeployment when the HTTP gatewayes become disabled #1450

amarthadan opened this issue Sep 14, 2022 · 1 comment · Fixed by #1456
Assignees
Milestone

Comments

@amarthadan
Copy link
Contributor

Based on the discussion in #1424

During the PR review for #1424 @Siegrift run into an issue where he got an error message noting a cyclic dependency in the Terraform recipes

Error: Cycle: module.httpSignedGw[0].aws_api_gateway_deployment.deployment (destroy), module.httpSignedGw[0].aws_api_gateway_rest_api.api_gateway (destroy), module.httpSignedReq[0].aws_lambda_function.lambda (destroy), module.httpSignedReq[0].null_resource.fetch_lambda_files (destroy), module.startCoordinator.aws_lambda_function.lambda

Steps to reproduce (not reliably though 😄):

  1. Deploy Airnode with both HTTP gateways enabled
  2. Redeploy the same Airnode (running deploy again without a removal) with one of the gateways disabled
  3. Redeploy the same Airnode (running deploy again without a removal) with both of the gateways disabled
@martinkolenic
Copy link
Contributor

Hi, @amarthadan, I'm happy to report that despite various combinations of gateways enabled and disabled (and then both of them disabled), the deployments have been successful so far. I'll move this to Done then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants