-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow listing of active Airnode deployments #1403
Comments
Deployer would need to be able to use multiple cloud provider credentials to be able to have the cloud provider column. That would be cool though (and useful especially for multi-region/project GCP deployments). |
Credentials for different cloud providers come from different sources so that shouldn't be a problem (even now). |
@aquarat @bbenligiray I've updated the description, let me know whether it makes sense this way. |
Looks good. How about this though? airnode-deployer list
Deployment ID Cloud provider Airnode address Stage Node version Last Update
1697238d AWS (us-east-1) 0x1234567... dev 0.7.3 2022-08-29T09:12:34+0000
ada40890 AWS (us-east-1) 0x1234567... prod 0.6.5 2022-09-29T07:34:33+0000
1c4dbc3d GCP (eu-central1) 0xabcdef0... mainnet-2 0.6.5 2022-08-12T10:17:09+0000 |
The longest part will be the Airnode address, not sure we can do much about it. The time is just not formatted yet. |
I was actually being literal with |
Small thing: if we want to go with shortened addresses, I think it's more common to include the last few characters as well. e.g. Something like |
I wanted to keep the full address because that's what they need to provide if they want to remove the Airnode without the receipt (with |
This is looking very good/polished. |
Agreed. Feels like "Airnode version" could be "Version" but I don't feel too strongly. |
I personally don't think we should be showing the "Airnode" ascii art for this. Feels like a big waste of space (although I do like it when deploying) |
Yeah, I was thinking the same thing. I'll keep the ASCII art only for the deploying and removal then. |
This is working very smoothly and is a great thing user experience-wise. It detects even an old deployment without any error. |
What do you mean by an old deployment? |
No idea why this wasn't closed automatically when the PR was merged. Closing. |
Hi @amarthadan, an old deployment = an older version of Airnode than the v0.10 branch (0.8 in this case). These were the testcases:
These all were displayed correctly by the listing utility. |
Allow users to list the active Airnode deployment via airnode-deployer CLI in a similar fashion as
docker ps
command.The output will be ordered by the cloud provider, Airnode address, region, stage, and Airnode version in this order. There's an argument to be made about ordering the list by the last update time but I would prefer if the output didn't move around every time I redeploy an Airnode. we can add options for multiple orderings later on.
The deployment ID will be constructed as the first 8 characters of
sha([cloudProvider, region, airnodeAddress, stage, airnodeVersion])
. The last update time is not included so the update to the given Airnode won't change it's deployment ID.There will be a
--cloud-providers
option allowing the listing of Airnodes only from the given cloud provider(s). With no option provided, the deployer will try to list all (both) the cloud providers.The text was updated successfully, but these errors were encountered: