Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heartbeatId from receipt.json #1296

Closed
Tracked by #1605
amarthadan opened this issue Jun 29, 2022 · 4 comments · Fixed by #1391
Closed
Tracked by #1605

Remove heartbeatId from receipt.json #1296

amarthadan opened this issue Jun 29, 2022 · 4 comments · Fixed by #1391

Comments

@amarthadan
Copy link
Contributor

When working on api3dao/old-api3-docs#825 I've noticed that we store heartbeat ID in the receipt.json even though it's just a copy of the heartbeat ID from config.json. To add to the confusion, we send that ID with the heartbeat with the name deployment_id. I propose removing the hearbeatId field from the receipt.json (and with it the whole api section as it will become empty).

@bbenligiray
Copy link
Member

As per yesterday's call we're planning to autogenerate the heartbeat ID similar to Lambda function names

@amarthadan
Copy link
Contributor Author

Is there a task for that? But in that case, we would probably want to keep the heartbeat ID in the receipt, right?

@bbenligiray
Copy link
Member

@aquarat was supposed to create a few tasks out of that call, I'm not sure if he did it yet. Not sure about the receipt question.

@martinkolenic
Copy link
Contributor

Hi, I've done this to test it:

  • turn on heartbeat in config and deploy the coingecko-signed-data example
  • check that the heartbeat ID is not present in receipt.json
  • do the same for an older version and check that the ID is actually present as control

Everything worked in line with expectations.

@aTeoke aTeoke modified the milestones: 0.9.0, 0.10.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants