Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.43.0 theme.mode: dark option overrides chart.background #4062

Closed
cart-before-horse opened this issue Oct 12, 2023 · 1 comment
Closed

3.43.0 theme.mode: dark option overrides chart.background #4062

cart-before-horse opened this issue Oct 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cart-before-horse
Copy link
Contributor

cart-before-horse commented Oct 12, 2023

theme.mode: "dark" option overrides chart.background: "transparent"

Steps to Reproduce

Create a chart with chart.background: "transparent" and theme.mode: "dark" options

Expected Behavior

chart.background: "transparent" takes precedence over theme.mode: "dark" like any other explicitly defined background color. Looks like dark mode treats background: transparent like background: undefined

Actual Behavior

background is always rgba(0, 0, 0, 0.8)

Screenshots

image

Reproduction Link

https://codepen.io/cart-before-horse/pen/ExGJjOa

from 9936ffc commit

@cart-before-horse cart-before-horse added the bug Something isn't working label Oct 12, 2023
@cart-before-horse
Copy link
Contributor Author

can be fixed by setting chart.background to none or rgba(0,0,0,0) instead of transparent but is doesn't feel right, since the color transparent was explicitly set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant