From a88a185dfbdbc2255129d8af35d71c4adf22c86c Mon Sep 17 00:00:00 2001 From: luozongle01 Date: Sat, 19 Oct 2024 00:46:59 +0800 Subject: [PATCH 1/2] ZOOKEEPER-4879: Fix log arguments typo --- .../java/org/apache/zookeeper/server/ZooKeeperServer.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java index 6740f6d524b..2a406e11214 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java @@ -1811,7 +1811,7 @@ private void processSasl(RequestRecord request, ServerCnxn cnxn, RequestHeader r } } } catch (SaslException e) { - LOG.warn("Client {} failed to SASL authenticate: {}", cnxn.getRemoteSocketAddress(), e); + LOG.warn("Client {} failed to SASL authenticate", cnxn.getRemoteSocketAddress(), e); if (shouldAllowSaslFailedClientsConnect() && !authHelper.isSaslAuthRequired()) { LOG.warn("Maintaining client connection despite SASL authentication failure."); } else { @@ -2375,7 +2375,7 @@ public boolean authWriteRequest(Request request) { try { request.cnxn.sendResponse(rh, null, null); } catch (IOException e) { - LOG.error("IOException : {}", e); + LOG.error("IOException", e); } } } From c389157464f2794c0cbd666cd1bb4073660d11bc Mon Sep 17 00:00:00 2001 From: luozongle01 Date: Mon, 28 Oct 2024 12:40:51 +0800 Subject: [PATCH 2/2] Update zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java Co-authored-by: Kezhu Wang --- .../main/java/org/apache/zookeeper/server/ZooKeeperServer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java index 2a406e11214..d6ab80b6acc 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java @@ -2375,7 +2375,7 @@ public boolean authWriteRequest(Request request) { try { request.cnxn.sendResponse(rh, null, null); } catch (IOException e) { - LOG.error("IOException", e); + LOG.warn("IOException", e); } } }