Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website redesign did not preserve Permalinks #247

Closed
sebbASF opened this issue Jul 19, 2023 · 8 comments
Closed

Website redesign did not preserve Permalinks #247

sebbASF opened this issue Jul 19, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@sebbASF
Copy link
Contributor

sebbASF commented Jul 19, 2023

As the subject says; the website redesign did not preserve all Permalinks in updated pages.

[Moved from ASFSITE-28]

@sebbASF sebbASF added the bug Something isn't working label Jul 19, 2023
@bproffitt
Copy link
Contributor

This is not helpful. Which specific permalinks were not preserved @sebbASF ?

@sebbASF
Copy link
Contributor Author

sebbASF commented Jul 24, 2023

The ones in the pages that were changed.
Renaming a section generally changes the Permalink.

Also the titles that were changed, as per: #227

I can probably write a script to find these, but I'm not keen to do so unless there is a firm commitment to restore the links.

@sebbASF
Copy link
Contributor Author

sebbASF commented Jul 24, 2023

Here is one example:
https://www-previous.staged.apache.org/foundation/press/kit/#template-for-the-creation-of-powered-by-logos
is now
https://apache.org/foundation/press/kit/#template-for-powered-by-logos

Whilst the new heading is shorter and better, that does not mean the old Permalink should no longer be supported.

@bproffitt
Copy link
Contributor

This question has shown up multiple places both on GitHub and Jira. We knew this would happen, confirmed the right process w/ Infra, and intentionally did not write redirects for every single link.

  • For content that stayed on the same page, it will direct to the top of that page.
  • For content we moved from one page to a completely different page, we created a redirect.

Initially a few people may be confused, but it should be much easier to find stuff on the site now than before because the navigation is simpler.

The current site has code that automatically creates anchor links for every header on a page. This is a bad practice. In the future redesign, we will probably be eliminating this as it creates this issue any time you change a header on a page - it makes the site brittle / people never wanting to change anything because they’re afraid people can’t find what they need. A person shouldn’t rely on anchor links to find what they need, but rather good navigation and a decent search engine.

So, for the record, we will not be addressing this issue. It's not needed, and that is my final decision on this.

@sebbASF
Copy link
Contributor Author

sebbASF commented Jul 24, 2023

So is the plan to eliminate all in-page anchors, regardless of page length or content?

@bproffitt
Copy link
Contributor

I believe the plan is to eliminate at least a majority of them, and certainly remove the function that auto-creates them. It has not been discussed in great detail, so I don't have the exact answer, and would not want to tell you the wrong thing.

@sebbASF
Copy link
Contributor Author

sebbASF commented Jul 25, 2023

Where is this plan being discussed?

@bproffitt
Copy link
Contributor

When we get to it, likely on press@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants