[Relax] Identify tuple unpack/repack in CanonicalizeBindings #17313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `CanonicalizeBindings` pass could identify and simplify a value that had been packed into a tuple, then extracted from it. (e.g. Simplifying `tup = (x,y); z = tup[0]` into `z = x`.) However, it could not identify a value that had been expanded from a tuple, and then re-bundled. (e.g. Simplifying `new_tuple = (tup[0], tup[1])` into `new_tuple = tup`.) This commit updates `CanonicalizeBindings` to identify and remove unnecessary tuple unpacking/repacking.
vinx13
approved these changes
Aug 28, 2024
Lunderberg
deleted the
relax_remove_tuple_round_trip_in_canonicalize_bindings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
CanonicalizeBindingspass could identify and simplify a value that had been packed into a tuple, then extracted from it. (e.g. Simplifyingtup = (x,y); z = tup[0]intoz = x.) However, it could not identify a value that had been expanded from a tuple, and then re-bundled. (e.g. Simplifyingnew_tuple = (tup[0], tup[1])intonew_tuple = tup.)This commit updates
CanonicalizeBindingsto identify and remove unnecessary tuple unpacking/repacking.