Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Remove mxnet dependency and re-enable rust example #17293

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Aug 22, 2024

Replace mxnet's resnet18 with torchvision.
Clean up import statements in rust/tvm/examples/resnet/src/build_resnet.py.
Related PR and Issue:

cc: @Hzfengsy @tqchen @cgerum

@mshr-h mshr-h changed the title [Rust] Re-enable Rust example [Rust] Remove mxnet dependency and re-enable Rust example Aug 22, 2024
@mshr-h mshr-h changed the title [Rust] Remove mxnet dependency and re-enable Rust example [Rust] Remove mxnet dependency and re-enable rust example Aug 22, 2024
@mshr-h mshr-h force-pushed the remove-mxnet-from-rust-example branch 3 times, most recently from 454db97 to 1ede00b Compare August 23, 2024 06:01
@mshr-h mshr-h marked this pull request as ready for review August 23, 2024 11:13
@mshr-h mshr-h force-pushed the remove-mxnet-from-rust-example branch from 1ede00b to 24d118f Compare August 29, 2024 08:39
@cgerum
Copy link
Contributor

cgerum commented Aug 31, 2024

I am not an official reviewer, but to me it looks very good.

@yongwww yongwww merged commit 73b138b into apache:main Sep 4, 2024
19 of 20 checks passed
@mshr-h mshr-h deleted the remove-mxnet-from-rust-example branch September 5, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants