Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][microTVM] Enable USE_MICRO for mac and windows CI builds #14393

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[CI][microTVM] Enable USE_MICRO for mac and windows CI builds #14393

merged 1 commit into from
Mar 24, 2023

Conversation

alanmacd
Copy link
Contributor

Enable USE_MICRO for mac and windows CI builds to ensure code building doesn't break for those platforms;

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 24, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@alanmacd alanmacd changed the title enable USE_MICRO for mac and windows CI builds [CI][microTVM] Enable USE_MICRO for mac and windows CI builds Mar 24, 2023
@mehrdadh
Copy link
Member

@driazati Will these changes be tested in CI or it has to be from a committer?

@leandron
Copy link
Contributor

leandron commented Mar 24, 2023

@driazati Will these changes be tested in CI or it has to be from a committer?

So the GitHub action that runs on Windows seems to have picked up the proposed change:

Based on that, I'd say it already run in CI.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alanmacd @mehrdadh

@alanmacd alanmacd marked this pull request as ready for review March 24, 2023 17:34
@mehrdadh mehrdadh merged commit 0d0d2f0 into apache:main Mar 24, 2023
@driazati
Copy link
Member

Yeah as @leandron saw these do get tested, the only things that need to be from a branch in apache/tvm are the jenkinsfiles and associated scripts (anything in ci/scripts/jenkins/* and ci/jenkins/generated/*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants