Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][docker] Use RFC image tags only #11938

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[ci][docker] Use RFC image tags only #11938

merged 1 commit into from
Jul 27, 2022

Conversation

driazati
Copy link
Member

@driazati driazati commented Jun 28, 2022 •
edited by github-actions bot
Loading

This ignores any images that don't match the pattern laid out in apache/tvm-rfcs#66

cc @Mousius @areusch

@driazati
[ci][docker] Use RFC image tags only
28d0ba9 
This ignores image names like `123-123-abc-validated`
@github-actions
Copy link
Contributor

Built docs for commit 28d0ba9 can be found here.

@driazati driazati marked this pull request as ready for review July 1, 2022 15:24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

It has been a while since this PR was updated, @Mousius @areusch please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@driazati driazati requested a review from areusch July 11, 2022 17:16
@areusch
Copy link
Contributor

areusch commented Jul 12, 2022

@driazati could you give a bit more context here? is there a bug describing what's wrong right now?

@driazati
Copy link
Member Author

it ignores any extra images that someone might manually push (or the validated ones that get pushed by ci with the name 123-123-abc-validated)

@github-actions
Copy link
Contributor

It has been a while since this PR was updated, @areusch @Mousius please leave a review or address the outstanding comments. @driazati if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@areusch
Copy link
Contributor

areusch commented Jul 25, 2022

@gigiblender could you review this one so you can understand how this tool works?

@gigiblender
Copy link
Contributor

@gigiblender could you review this one so you can understand how this tool works?

@areusch Sure

@gigiblender
Copy link
Contributor

gigiblender commented Jul 26, 2022 •
edited
Loading

Thanks @driazati! LGTM!

cc'ing @areusch to approve.

@areusch areusch merged commit 465b579 into apache:main Jul 27, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@driazati @xinetzone
[ci][docker] Use RFC image tags only (apache#11938)
5318c7e 
This ignores image names like `123-123-abc-validated`

Co-authored-by: driazati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areusch areusch areusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driazati @areusch @gigiblender