Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Tracking Issue for TECompiler #7526

Closed
7 tasks
jroesch opened this issue Feb 24, 2021 · 4 comments
Closed
7 tasks

[RFC] Tracking Issue for TECompiler #7526

jroesch opened this issue Feb 24, 2021 · 4 comments
Labels
type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs

Comments

@jroesch
Copy link
Member

jroesch commented Feb 24, 2021

Tracking issue for te_compiler.

About tracking issues

Tracking issues are used to record the overall progress of implementation and relevant issues.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
For open ended discussion, check out: https://discuss.tvm.apache.org/.

Implementation

Unresolved Questions

How to unify passes across backends?

@Mousius
Copy link
Member

Mousius commented Aug 6, 2021

@jroesch are there plans to include AOT in this now?

@mbaret mbaret added the type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs label Aug 6, 2021
@jroesch
Copy link
Member Author

jroesch commented Nov 29, 2021

cc @mbs-octoml @denise-k is it possible for you guys to take over this one as you now have the most context?

@mbs-octoml
Copy link
Contributor

Here's where we've gotten to:

  1. TECompiler has fully replaced CompileEngine :-)
  2. te_complier_cache.cc still in pretty messy state, the cache datastructures themselves can be simplified however we still have customers of TECompiler::Lower etc via te_compiler.py.
  3. After [Relay] Switch the VM to use the LowerTE pass instead of TECompiler::{Lower,LowerShapeFunc}. #9483 all backends will use the TELowerPass instead of the one-function-at-a-time lowering API.
  4. IRModule could do with better support for external functions, runtime::Modules and generated AOT source code.

At some point I'd lie to tackle 2 head-on, that will require discussion to figure out how to move folks off of depending on the CCache* structures and one-function-at-a-time.

And 4 can also be split out.

Close this one?

@jroesch
Copy link
Member Author

jroesch commented Nov 30, 2021

Ok Mark will split out into follow up issues that go on the roadmap and we will close this one. cc @Mousius

@jroesch jroesch closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:rfc-tracking RFC progress tracking. Ref: https://github.com/apache/tvm-rfcs
Projects
None yet
Development

No branches or pull requests

4 participants