Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Support aten::tensor, aten::empty and aten::numel #6535

Closed
zhiqwang opened this issue Sep 23, 2020 · 4 comments
Closed

[Torch] Support aten::tensor, aten::empty and aten::numel #6535

zhiqwang opened this issue Sep 23, 2020 · 4 comments

Comments

@zhiqwang
Copy link
Contributor

Hi TVM teams,

TVM currently support pytorch 1.4 and torchvision 0.5. I want to know is there any plan to support pytorch 1.6 version to trace the object detection models in pytorch 1.6?

For faster rcnn, which is not partly scripted and thus can be traced completely, I get following missing ops with PyTorch 1.6

NotImplementedError: The following operators are not implemented: ['aten::tensor', 'aten::empty', 'aten::numel']

Originally posted by @masahi in #6449 (comment)

@masahi
Copy link
Member

masahi commented Sep 23, 2020

Yes, we want to support a newer version but our quantization support is completely broken in PyTorch 1.6 due to the breaking change they introduced pytorch/pytorch#42497. I don't know a simple workaround for this.

Either we wait for Torch people to fix this issue or we spend significant effort to add workaround. Until then we are stuck with 1.4 or 1.5 (CI is at 1.4)

The ops aten::tensor, aten::empty, and aten::numel are very trivial ops actually, so if you want to just convert 1.6 detection models, adding support for them shouldn't be hard. You don't need to wait for 1.6 support.

@masahi
Copy link
Member

masahi commented Sep 30, 2020

We'll track 1.6 support at #6594

@masahi masahi closed this as completed Sep 30, 2020
@zhiqwang
Copy link
Contributor Author

Hi, That's great news! Relink it to #6594 ?

@masahi
Copy link
Member

masahi commented Sep 30, 2020

ah sorry, the link is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants