Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conv2d grad for strided cases under the new conv2d_transpose def #6179

Closed
tqchen opened this issue Jul 30, 2020 · 7 comments · Fixed by #6236
Closed

Fix conv2d grad for strided cases under the new conv2d_transpose def #6179

tqchen opened this issue Jul 30, 2020 · 7 comments · Fixed by #6236
Labels
test: flaky

Comments

@tqchen
Copy link
Member

tqchen commented Jul 30, 2020

https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-6173/3/pipeline
@tqchen
Copy link
Member Author

tqchen commented Jul 30, 2020

An additional note is that we should change the grad verification to use numerical grad checking instead of Pytorch

@tqchen
Copy link
Member Author

tqchen commented Jul 30, 2020

cc @jroesch @MarisaKirisame @junrushao1994 @antinucleon

@areusch
Copy link
Contributor

areusch commented Jul 31, 2020

I bisected this by building with ci-gpu and running tests/python/relay/test_op_grad_level2.py 10 times, I believe the offending PR is #5758

@tqchen
Copy link
Member Author

tqchen commented Jul 31, 2020

@vinx13 it would be great if you can followup on this thread

@tqchen tqchen changed the title [TESTS][FLAKY] tests/python/relay/test_op_grad_level2.py: verify_conv2d_grad Fix conv2d grad for strided cases under the new conv2d_transpose def Jul 31, 2020
@tqchen
Copy link
Member Author

tqchen commented Jul 31, 2020 •
edited
Loading

In particular, it seems that we will need to fix the conv2d grad def under the new spec of conv2d_transpose introduced in #5758. Thanks @areusch for finding the offending PR

@vinx13
Copy link
Member

vinx13 commented Jul 31, 2020

I will take a look

@tqchen
Copy link
Member Author

tqchen commented Aug 3, 2020

NOTE, the test is temporarily disabled in #6183, we will update this issue again once @vinx13 fix the problem

@vinx13 vinx13 mentioned this issue Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test: flaky
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TOPI, Cuda] Fix conv2d_transpose output padding vinx13/tvm
3 participants
@areusch @tqchen @vinx13