Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test][CPPTEST] File is not tested ./tests/cpp/relay_transform_sequential.cc #5744

Closed
junrushao opened this issue Jun 7, 2020 · 3 comments
Closed

[Test][CPPTEST] File is not tested ./tests/cpp/relay_transform_sequential.cc #5744

junrushao opened this issue Jun 7, 2020 · 3 comments

Comments

@junrushao
Copy link
Member

Occasionally I found that this file is not tested in our master's CI pipeline, and the primary reason is that the test launcher ./tests/scripts/task_cpp_unittest.sh only finds executables ending with "_test"...I manually ran the file but it fails, because some global packed functions are renamed...

CC: @zhiics if you are interested in reviving this unit test :-)
@zhiics
Copy link
Member

zhiics commented Jun 7, 2020

ahh, sorry about that. It worked locally before. Recently we changed schedule registration. That's probably why it fails.

@zhiics zhiics mentioned this issue Jun 7, 2020
Merged
@zhiics
Copy link
Member

zhiics commented Jun 7, 2020

#5745

@junrushao
Copy link
Member Author

Closed via #5745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhiics @junrushao