-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] PassContext.fallback_device -> PassConfig.config #5650
Comments
@tqchen Thanks for reminding. I will take a stab next week. |
I realize we may also want to remove |
I agree we should do that as well |
One potential problem is that it may break downstream deployment. |
We could mark build_config as deprecation, and remove that API in the next release cycle. In the meanwhile, we should replace all of the current usages. |
Sounds like a good plan. |
#5631 Introduces a generic config mechanism to store the pass configuration options. Given that fallback_device is a pas related config, We should probably also migrate PassContext->fallback_device to a special config. e.g.
relay.fallback_device_type
with IntImmNode as its node typeThe text was updated successfully, but these errors were encountered: