New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PYTHON] Remove developer facing api from frontend exports #5342

Closed

tqchen opened this issue Apr 15, 2020 · 2 comments

Labels

status: help wanted

Member

tqchen commented Apr 15, 2020 •

edited

Loading

Just find this case when going through the doc generation process. We only want to expose from_xxx in the relay.frontend namespace as public APIs.

The functions being used in test, e.g. quantize_mxnet_min_max should be explicitly imported in testcases via from ``tvm.relay.frontend.mxnet_qnn_op_utils import xyz`

https://github.com/apache/incubator-tvm/blob/master/python/tvm/relay/frontend/__init__.py#L27

The text was updated successfully, but these errors were encountered:

Member Author

tqchen commented Apr 15, 2020

cc @anijain2305 @shoubhik

tqchen added the status: help wanted label

Contributor

shoubhik commented Apr 15, 2020

I'll submit the changes tomorrow.

shoubhik mentioned this issue

Remove developer facing api from frontend exports. #5375

Merged

tqchen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment