Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] StringImm -> String #5250

Closed
2 tasks done
tqchen opened this issue Apr 6, 2020 · 3 comments
Closed
2 tasks done

[REFACTOR] StringImm -> String #5250

tqchen opened this issue Apr 6, 2020 · 3 comments

Comments

@tqchen
Copy link
Member

tqchen commented Apr 6, 2020

We have introduced the runtime::String to the tvm runtime. This new object can be used to replace most of the StringImm usages, except for the one that uses the IR. This issue tracks the refactor items to perform such migration.

@tqchen
Copy link
Member Author

tqchen commented Apr 6, 2020

cc @wweic @zhiics please see if you can take the rest of the items in the incoming week

@zhiics
Copy link
Member

zhiics commented Apr 7, 2020

@tqchen I will spend some time on this. I just had simple test based on #5251. It looks I had a problem. Could you please take a look at the comment there?

@tqchen
Copy link
Member Author

tqchen commented Apr 10, 2020

closed by #5276 Thanks to @zhiics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants