Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build failing with nnpack depreciation error #4086

Closed
lhutton1 opened this issue Oct 8, 2019 · 2 comments
Closed

Docker build failing with nnpack depreciation error #4086

lhutton1 opened this issue Oct 8, 2019 · 2 comments

Comments

@lhutton1
Copy link
Contributor

lhutton1 commented Oct 8, 2019

I've recently just tried to build tvm using the docker image provided in the repo. I'm getting the following depreciation errors when trying to build with nnpack enabled:

In file included from /NNPACK/build/include/nnpack.h:7:0,
                 from /workspace/src/contrib/nnpack/fully_connected.cc:27:
/NNPACK/build/include/pthreadpool.h:185:14: error: 'pthreadpool_function_1d_t' is deprecated [-Werror=deprecated-declarations]
  size_t range);

[more depreciation warnings....]

cc1plus: all warnings being treated as errors
CMakeFiles/tvm_runtime.dir/build.make:758: recipe for target 'CMakeFiles/tvm_runtime.dir/src/contrib/nnpack/nnpack_utils.cc.o' failed
make[4]: *** [CMakeFiles/tvm_runtime.dir/src/contrib/nnpack/nnpack_utils.cc.o] Error 1
@mshawcroft
Copy link
Contributor

Confirmed. The version of nnpack pulled and built by tvm is pinned. However it appears that nnpack itself clones the pthreadpool project and checks out the most recent master of that project. Ideally we should have a way of properly pinning nnpack and it's dependent packages in order to have a stable build environment for tvm.

@tqchen
Copy link
Member

tqchen commented Oct 18, 2019

should be resolved by #4152 thanks for reporting the problem

@tqchen tqchen closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants