Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Share Relay op Infer Type functions #3784

Closed
anijain2305 opened this issue Aug 15, 2019 · 3 comments
Closed

[Relay] Share Relay op Infer Type functions #3784

anijain2305 opened this issue Aug 15, 2019 · 3 comments

Comments

@anijain2305
Copy link
Contributor

anijain2305 commented Aug 15, 2019

Currently, all the infer types functions for Relay are present in *.cc file. This prevents us from reusing these functions among dialects like QNN. This issue is to discuss how do we share them.

I added a PR that moves relevant functions to a header file for transform.cc as a possible proposal - #3783

Please advise - @jroesch @tqchen @vinx13 @zhiics @ZihengJiang

@anijain2305
Copy link
Contributor Author

Ping :)

Many QNN related ops are gated by it. I am able to get good accuracy for all the TFLite hostel models locally. Will be good if we can solve these problems and ungate a bunch of QNN PRs.

@tqchen
Copy link
Member

tqchen commented Aug 29, 2019

A proper way would be open a thread with RFC tag, so it would get forwarded to the dev@. I think we could move forward with templatization for now.

@tqchen tqchen closed this as completed Aug 29, 2019
@anijain2305
Copy link
Contributor Author

Thank you @tqchen
I will keep that in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants