Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials/Docs are break due to frontend API change #3399

Closed
antinucleon opened this issue Jun 19, 2019 · 4 comments
Closed

Tutorials/Docs are break due to frontend API change #3399

antinucleon opened this issue Jun 19, 2019 · 4 comments

Comments

@antinucleon
Copy link
Contributor

antinucleon commented Jun 19, 2019

Att.. API is changed in https://github.com/dmlc/tvm/pull/3353/files
However doc and tutorials/docs such as AutoTVM are not updated.

Also I suggest to add a warning of this change, as it breaks all old code.

@tqchen
Copy link
Member

tqchen commented Jun 19, 2019

The RFC was #3346 I agree it would be good to raise a bit more attention. @antinucleon can you point out which of the files that haven't been updated?

@zhiics
Copy link
Member

zhiics commented Jun 20, 2019

#3401

@antinucleon Are you aware of any other places might miss the change?

@antinucleon
Copy link
Contributor Author

Can we add a deprecated warning in frontend for 0.6 and remove in 0.7?

@tqchen
Copy link
Member

tqchen commented Jun 20, 2019

Due to the fact that this is a return value, it is harder to deprecate the frontend API this time. Given that this is a major change that is necessary to enable more models(with loops recursion). I suggest we keep the change, but create another RFC notification thread in the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants