Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Jenkins workers has old tflite package #3373

Closed
apivovarov opened this issue Jun 14, 2019 · 4 comments
Closed

[CI] Jenkins workers has old tflite package #3373

apivovarov opened this issue Jun 14, 2019 · 4 comments

Comments

@apivovarov
Copy link
Contributor

apivovarov commented Jun 14, 2019

1 day ago I updated ubuntu_install_tflite.sh to use tflite schema version 1.13
https://github.com/dmlc/tvm/blob/master/docker/install/ubuntu_install_tflite.sh#L38
PR was merged 1 day ago
#3356

After that I started two build which uses new tflite classes from v1.13
Both builds failed because they can not find new tflite classes which means that Jenkins workers still use old tflite v1.12
http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3370/2/pipeline/
http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3370/1/pipeline/
Integration test - frontend GPU error:

Running relay TFLite frontend test...
  File "/workspace/python/tvm/relay/frontend/tflite.py", line 235, in _convert_resize
    from tflite.ResizeNearestNeighborOptions import ResizeNearestNeighborOptions

PR which uses new tflite classes #3370
tflite schema v1.13 - https://raw.githubusercontent.com/tensorflow/tensorflow/r1.13/tensorflow/lite/schema/schema.fbs

@apivovarov
Copy link
Contributor Author

@tqchen Can you help me to solve the issue with old tflite package on Jenkins workers?

@tqchen
Copy link
Member

tqchen commented Jun 14, 2019

The CI image uses a cached image, and need to be staged manually. This is to ensure we have a stable build env. See note here: https://docs.tvm.ai/contribute/pull_request.html#ci-environment

However, do expect a bit delays as we want to update the images infrequently, and there might be consistency issues when updating the docker image

A quick way to get around would make sure that the solution can be compatible with both versions (also helpful for users as well). This will also be helpful as the change of the state might be compatible: we need to change the image and the test at the same time and sometimes it breaks things

I will send an update note when the docker image gets updated.

@tqchen tqchen changed the title Jenkins workers has old tflite package [CI] Jenkins workers has old tflite package Jun 14, 2019
@apivovarov
Copy link
Contributor Author

apivovarov commented Jun 14, 2019

ok, I fixed my PR to support both tflite versions 1.12 and 1.13

@tqchen
Copy link
Member

tqchen commented Jun 18, 2019

Now that #3374 has been merged, the CI should have been updated to the latest state including the tflite change

@tqchen tqchen closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants