From fbb5f707a6cbace4821cf3076fff0eb81dd39d49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=9B=BE=E9=9B=A8=E9=AD=94=E7=90=86=E6=B2=99?= Date: Thu, 25 Oct 2018 09:39:49 -0700 Subject: [PATCH] [Relay] fix small typekey issue (#1992) It might cause TupleTypeNode to be printed incorrectly. it doesnt show in http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1989/1/pipeline/141, but if you run it on local machine you will see what get compared being NodeBase and TupleType. Also as a side thought can we write a giant macro that make sure everything get did right (all field get visited, typekey match, declare_node_type_info match, etc?) I can do some macro metaprogramming, so I can take up the work. --- include/tvm/relay/type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/tvm/relay/type.h b/include/tvm/relay/type.h index 5d8eca037013..6ff2be5e69d7 100644 --- a/include/tvm/relay/type.h +++ b/include/tvm/relay/type.h @@ -251,7 +251,7 @@ class TupleTypeNode : public TypeNode { TVM_DLL static TupleType make(tvm::Array fields); - static constexpr const char* _type_key = "relay.TypeTuple"; + static constexpr const char* _type_key = "relay.TupleType"; TVM_DECLARE_NODE_TYPE_INFO(TupleTypeNode, TypeNode); };