Skip to content

Commit

Permalink
Update rfcs/0000-docker-image-tags.md
Browse files Browse the repository at this point in the history
Co-authored-by: Christopher Sidebottom <[email protected]>
  • Loading branch information
leandron and Mousius committed Jun 1, 2022
1 parent f6904d6 commit 8170fd3
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- Feature Name: docker_image_tag_format
- Start Date: 2022-04-08
- RFC PR: [apache/tvm-rfcs#0000](https://github.com/apache/tvm-rfcs/pull/0000)
- RFC PR: [apache/tvm-rfcs#0066](https://github.com/apache/tvm-rfcs/pull/66)
- GitHub Issue: [apache/tvm#0000](https://github.com/apache/tvm/issues/0000)

# Summary
Expand All @@ -26,7 +26,7 @@ None of these questions can be answered by our current numbering scheme, and to

# Reference-level explanation

As an improvement to the current situation, this RFC proposes the adption of a tagging scheme currently used in the `tlcpackstaging` (https://hub.docker.com/u/tlcpackstaging) repository, composed by:
As an improvement to the current situation, this RFC proposes the adoption of a tagging scheme currently used in the `tlcpackstaging` (https://hub.docker.com/u/tlcpackstaging) repository, composed by:

* a timestamp YYYYMMDD-HHMMSS
* the last short git hash added in that image
Expand All @@ -37,7 +37,7 @@ The advantage with the proposed scheme, is that we can just look back on our own

# Drawbacks

Pointing to "the previous image" is obvious today, because it is just "the current version minus one". To revert the image in the proposed tagging scheme, we will need to adapt this process and use git history to discover which was the previous version in the repository. However, reverting images is quite rare so it should be something the will consume lots of time very often.
Pointing to "the previous image" is obvious today, because it is just "the current version minus one". To revert the image in the proposed tagging scheme, we will need to adapt this process and use git history to discover which was the previous version in the repository. However, revert is quite rare but it will consume lots of time very often.

# Rationale and alternatives

Expand Down

0 comments on commit 8170fd3

Please sign in to comment.