Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delivery Service/server assignment safeties #5328

Merged
merged 46 commits into from
Dec 9, 2020
Merged

Delivery Service/server assignment safeties #5328

merged 46 commits into from
Dec 9, 2020

Conversation

ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops
  • Traffic Ops client (Go)

What is the best way to verify this PR?

Run the API tests

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. labels Nov 24, 2020
@ocket8888 ocket8888 changed the title Delivery Service/server assignment safties Delivery Service/server assignment safeties Nov 24, 2020
@rawlinp rawlinp self-assigned this Dec 2, 2020
rawlinp
rawlinp requested changes Dec 3, 2020
View reviewed changes
traffic_ops/testing/api/v3/deliveryserviceservers_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v3/deliveryserviceservers_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v3/deliveryserviceservers_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v3/deliveryserviceservers_test.go Show resolved Hide resolved
traffic_ops/testing/api/v3/deliveryserviceservers_test.go Show resolved Hide resolved
traffic_ops/traffic_ops_golang/server/servers_assignment.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/server/servers_assignment.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/server/servers_assignment.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/server/servers_assignment.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/server/servers_assignment.go Outdated Show resolved Hide resolved
@ocket8888
Add unassignment safeties to DELETE deliveryserviceserver/dsID/serverID
f4b1f2f
@ocket8888
Add GoDoc
a45bbc5
@ocket8888
Add ds assignment safeties to DELETE /servers handler
d764c65
@ocket8888
Some cleanup and added GoDocs
6efe986
@ocket8888
Swap structure definition from ServerNullable to ServerV30
3bad28c
@ocket8888
Add DS assignment safeties to server update
64f1bef
@ocket8888
Fix unit tests
ce53e11
@ocket8888
Add DS assignment safeties to /servers/{{ID}}/status endpoint
8b60592
@ocket8888
Add ds assignment safeties to /deliveryserviceserver
d1b623a
@ocket8888
Fix rebase issues
293b555
@ocket8888
Fix segfault
2db5379
@ocket8888
Add tests
3fdfdf6
@ocket8888
Fix bad query, fix servers being deleted when they shouldn't be
03ca7a2
@ocket8888
Fix silent segfault in DSSA tests
bca687b
@ocket8888
Fix a DSSA test to not invalidate DS
b6dc703
@ocket8888
Fix server capability test to not invalidate DS
8ea8c80
@ocket8888
Fixed server/{{ID}}/deliveryservices not checking for DS invalidation
ca0012e
@ocket8888
Fix server status updates returning incorrect alert-levels
df55f2a
@ocket8888
Update v1 and v2 tests to not invalidate delivery services
ea33626
@ocket8888
Fix DeleteTestCachegroupsDeliveryServices invalidating Delivery Services
16f2b5c
@ocket8888
Fix servers tests invalidating DSes during server deletion
bb68896
@ocket8888
Added CI test output files to .gitignore(s)
332d240
@ocket8888
Fix servers endpoint to use server last updated time as default statu…
538407c 
…s last updated time in the event the server doesn't have the latter
@ocket8888
Move test under entrypoint
97d27cf
@ocket8888
Remove redundant 'if'
d07664e
@ocket8888
Fix import grouping
6c1a3de
@ocket8888
Fix spelling in a GoDoc
f125ad4
@ocket8888
Switch PUT servers/{{ID}}/status to use single alert per conflict
fa1f587
@ocket8888
Add missing return after error handling
f93998f
@ocket8888
switch hard-coded statuses to library constants
2f60edb
@ocket8888
Remove redundant assignment
1f6d19f
@ocket8888
Fix /api/1.x/servers returning v3 server structures
5cfe1e2
@ocket8888
Fix resource leak (not closing SQL rows)
16eada4
@ocket8888
Make function name more explicit
9515a33
@ocket8888
Switch query from using hard-coded values to library constants
5b223c5
@ocket8888
remove debug log statements
6f75273
@ocket8888
Switch from hard-coded values to library constants
4e80d17
@ocket8888
Switch PUT /servers to use single alert instead of one per violation
9866c17
@ocket8888
Switch DELETE /servers to use a single alert instead of one per viola…
5e12d63 
…tion
@ocket8888
Switch POST /servers/{{ID}}/deliveryservices to use a single alert in…
b1ad981 
…stead of one per violation
@ocket8888
Revert change to client call signature
b57e39f
@ocket8888
Fix DS conflicts writing wrong response code
f6d2acf
@ocket8888
Fix segfault in DS v3 tests
212cf05
@ocket8888
Add DSSA Safeties testing data to v3 fixtures
de6e6b6
@ocket8888
Fix v3-client function returning a v1.5 DS structure, which can and w…
de4f783 
…ill break since requests are made against v3.0
@ocket8888
Switch from manual setup to using fixture data
a2a7c32
@ocket8888 ocket8888 force-pushed the to/ds-server-assignment-safties branch from 3d2a2f1 to a2a7c32 Compare December 4, 2020 21:40
rawlinp
rawlinp approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all my comments were resolved, and the tests pass. Also did a quick test in TP -- worked as expected.

@rawlinp rawlinp merged commit d710192 into apache:master Dec 9, 2020
@rawlinp
Copy link
Contributor

rawlinp commented Dec 9, 2020

Oh, whoops, I didn't see an addition to CHANGELOG.md -- @ocket8888 mind opening a follow-up PR to add one?

@rawlinp rawlinp mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob05c rob05c rob05c left review comments

@rawlinp rawlinp rawlinp approved these changes

Assignees

@rawlinp rawlinp

Labels
improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delivery service server assignment safeties to Traffic Ops
3 participants
@ocket8888 @rawlinp @rob05c