Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect description of delivery service max dns answers in TP and documentation #5382

Closed
mitchell852 opened this issue Dec 17, 2020 · 2 comments · Fixed by #5403
Closed
Assignees
Labels
bug something isn't working as intended documentation related to documentation Traffic Portal v1 related to Traffic Portal version 1

Comments

@mitchell852
Copy link
Member

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Documentation
  • Traffic Portal

Current behavior:

Incorrect description of delivery service max dns answers found here:

  1. https://traffic-control-cdn.readthedocs.io/en/latest/overview/delivery_services.html#max-dns-answers
  2. On the TP DNS and HTTP delivery service forms. ie. https://tp.domain.tld/#!/delivery-services/new?type=DNS:

image

Expected behavior:

Max DNS answers applies to both DNS* and HTTP* delivery services but I think the behavior is different for each so a different description is required for each. This is probably sufficient for DNS:

The maximum number of Edge-tier cache server IP addresses that the Traffic Router will include in responses to DNS requests. When provided, the cache server IP addresses included are rotated in each response to spread traffic evenly. This number should scale according to the amount of traffic the Delivery Service is expected to serve.

Not really sure what the description is for HTTP delivery services. Must be related to ETR (edge traffic routing) somehow. Maybe @elsloo can shed some light for us :)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 documentation related to documentation labels Dec 17, 2020
@rimashah25
Copy link
Contributor

I can take this one

@rawlinp
Copy link
Contributor

rawlinp commented Jan 5, 2021

That description that @mitchell852 proposed does sound sufficient for DNS delivery services. For HTTP delivery services, I think it only overrides the edge.http.limit parameter when both are set:

edge.http.limit | CRConfig.json | Integer that controls the default number of records returned when edge.http.routing is set to true; this can be overridden by the maxDnsAnswers delivery service setting

So maybe a good description for maxDnsAnswers in the HTTP DS form is:

If the Traffic Router profile parameter "edge.http.limit" is set, setting this to a non-zero value will override that parameter for this delivery service, limiting the number of Traffic Router IP addresses (A records) that are included in responses to DNS requests for this delivery service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended documentation related to documentation Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants