Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO pre 5.0 server list, network ip and ilo ip were clickable without going into server details. #5317

Closed
saoyag001 opened this issue Nov 20, 2020 · 6 comments · Fixed by #5519 · May be fixed by #5332
Closed

TO pre 5.0 server list, network ip and ilo ip were clickable without going into server details. #5317

saoyag001 opened this issue Nov 20, 2020 · 6 comments · Fixed by #5519 · May be fixed by #5332
Assignees
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Milestone

Comments

@saoyag001
Copy link
Contributor

saoyag001 commented Nov 20, 2020

  • bug report

  • Traffic Portal

Current behavior:

in TP clicking a link in server list page(ilo/network IP) opens a new window with ssh:// and brings you to that server details page.

Expected behavior:

in TP clicking a link in server list page (ilo/network IP) opens a new window with ssh:// and existing window remains on server list page.

Minimal reproduction of the problem with instructions:

click on any network link from the server list page

Anything else:

also ilo ip link should be https:// not ssh://
-->

@saoyag001 saoyag001 added the bug something isn't working as intended label Nov 20, 2020
@rawlinp rawlinp added the Traffic Portal v1 related to Traffic Portal version 1 label Nov 20, 2020
@mitchell852 mitchell852 added regression bug a bug in existing functionality introduced by a new version and removed bug something isn't working as intended labels Nov 20, 2020
@mitchell852
Copy link
Member

mitchell852 commented Nov 20, 2020

Here are the "ip addresses" associated with a server object.

ILO IP Address
ILO IP Gateway
ILO IP Netmask
IPv6 Address
IPv6 Gateway
Network IP (IPv4)
Network Gateway (IPv4)
Network Subnet  (IPv4)
Mgmt IP Address
Mgmt IP Gateway
Mgmt IP Netmask

What is the desired behavior when clicking each?

@rgresino
Copy link

ILOs tend to be Graphical although they do have CLIs in some cases. As an SRE, I'd prefer to be able to set the desired behavior.
When I click on the ILO IP, I'd like to be able to set a static https://staticUserName@[ILO_IP_Address] or for other users that might wish ssh://$USERNAME@[ILO_IP_Address]

I think the use case is similar for IPv6 Address and IPv4 Address in that I'd like to be able to send: ssh://$Username@IPv4|6_Address.

Typically we would never do anything with Netmasks or Gateways (although smaller CDN might.)

@MylesBock
Copy link
Contributor

I'll take a crack at this, mostly to redeem myself to @saoyag001 for those RLR DS's about this time last year 😹

May I be assigned this issue?

@MylesBock
Copy link
Contributor

Thanks!

@MylesBock
Copy link
Contributor

@rgresino I will break out that desired behavior into a separate issue

@mitchell852 mitchell852 added this to the 5.1.0 milestone Feb 9, 2021
@mitchell852 mitchell852 assigned mitchell852 and unassigned MylesBock Feb 12, 2021
@mitchell852
Copy link
Member

Based on the feedback, I'm going to implement this functinality:

IPv4 Address click takes you to ssh://$Username@IPv4_Address
IPv4 Gateway click does nothing
IPv4 Subnet click does nothing
IPv6 Address click takes you to ssh://$Username@IPv6_Address
IPv6 Gateway click does nothing
Mgmt IP Address click takes you to ssh://$Username@mgmt_ip_Address
Mgmt IP Gateway click does nothing
Mgmt IP Netmask click does nothing
ILO IP Address click takes you to https://$ILOUsername@[ILO_IP_Address] 
ILO IP Gateway click does nothing
ILO IP Netmask click does nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
5 participants