Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO: Type validation for steering targets #3531

Closed
moltzaum opened this issue Apr 26, 2019 · 0 comments · Fixed by #4734
Closed

TO: Type validation for steering targets #3531

moltzaum opened this issue Apr 26, 2019 · 0 comments · Fixed by #4734
Labels
bug something isn't working as intended documentation related to documentation Traffic Ops related to Traffic Ops

Comments

@moltzaum
Copy link
Contributor

POST /api/1.1/steering/:id/targets

{
    "targetId": 8,
    "typeId", 7,
    "value": 100
}

This endpoint doesn't perform validation on the type id. The only valid types are STEERING_ORDER, STEERING_WEIGHT, STEERING_GEO_ORDER, and STEERING_GEO_WEIGHT.

I came across this while reading the documentation, where the HTTP type is used.

The description for 'value' in the documentation shouldn't correspond just to the weight, but to any of the types that are posted.

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops documentation related to documentation bug something isn't working as intended labels Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended documentation related to documentation Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants