From 02679c73a233c68fa946ccbe51933fb34df79bf0 Mon Sep 17 00:00:00 2001 From: Orion Poplawski Date: Wed, 17 Feb 2021 07:52:49 -0700 Subject: [PATCH] char is unsigned on non-x86 arches, use signed char to avoid compiler warning about always true comparisons. Fixes THRIFT-5350. --- compiler/cpp/src/thrift/generate/t_delphi_generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc index d3ad76a32d2..eac46a6c7c0 100644 --- a/compiler/cpp/src/thrift/generate/t_delphi_generator.cc +++ b/compiler/cpp/src/thrift/generate/t_delphi_generator.cc @@ -1062,7 +1062,7 @@ std::string t_delphi_generator::make_pascal_string_literal(std::string value) { } result << "'"; - for (char const &c: value) { + for (signed char const c: value) { if( (c >= 0) && (c < 32)) { // convert ctrl chars, but leave UTF-8 alone result << "#" << (int)c; } else if (c == '\'') {