Introduce an onInit method for when a new viz_type is selected #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for clearing certain controls where/when needed. For instance here, when loading deck_scatter, even if there was a time granularity picked for the previous viz_type, we want to unselect it.
mistercrunch
force-pushed
the
init_viztype
branch
from
e1412ad
to
cc794c2
Compare
hughhhh
reviewed
Feb 28, 2018
| @@ -81,6 +81,9 @@ export function getControlsState(state, form_data) { | |||
| control.value = formData[k] !== undefined ? formData[k] : control.default; | |||
| controlsState[k] = control; | |||
| }); | |||
| if (viz.onInit) { | |||
| viz.onInit(controlsState); | |||
There was a problem hiding this comment.
shouldn't we just return viz.onInit(controlState) Then in the function we can just return a new object. For example in visType.js we could now do this.
onInit: (controlState) => {
return {
...controlState
time_grain_sqla: {
value: null
}
granularity: {
value: null
}
}
}
There was a problem hiding this comment.
gets a bit more verbose I think:
onInit: (controlState) => {
return {
...controlState
time_grain_sqla: {
...controlState.time_grain_sqla,
value: null,
}
granularity: {
...controlState.granularity,
value: null,
}
}
}it's clearly more functional / immutable, let me change it
mistercrunch
force-pushed
the
init_viztype
branch
from
1791eb9
to
3e152f9
Compare
|
@hughhhh addressed your comment, merging so I can package an internal release |
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Feb 28, 2018
…e#4491) * Introduce an onInit method for when a new viz_type is selected This allows for clearing certain controls where/when needed. For instance here, when loading deck_scatter, even if there was a time granularity picked for the previous viz_type, we want to unselect it. * making it functional (cherry picked from commit 264822b)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
* c2b42c4 - Change limit form 50k to 10k apache#4496 * 2932585 - [geo] add controls for minRadiusPixels and maxRadiusPixels in deck_scatter apache#4467 * 264822b - Introduce an onInit method for when a new viz_type is selected apache#4491
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…e#4491) * Introduce an onInit method for when a new viz_type is selected This allows for clearing certain controls where/when needed. For instance here, when loading deck_scatter, even if there was a time granularity picked for the previous viz_type, we want to unselect it. * making it functional
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…e#4491) * Introduce an onInit method for when a new viz_type is selected This allows for clearing certain controls where/when needed. For instance here, when loading deck_scatter, even if there was a time granularity picked for the previous viz_type, we want to unselect it. * making it functional
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for clearing certain controls where/when needed. For
instance here, when loading deck_scatter, even if there was a time
granularity picked for the previous viz_type, we want to unselect it.