Add permission checks to save_or_overwrite_slice #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
reviewed
Feb 8, 2018
superset/views/core.py
Outdated
| @@ -1182,6 +1182,11 @@ def explore(self, datasource_type, datasource_id): | |||
| "You don't have the rights to alter this slice", | |||
| status=400) | |||
|
|
|||
| if action == 'saveas' and not slice_add_perm: | |||
| return json_error_response( | |||
| "You don't have the rights to create this slice", | |||
There was a problem hiding this comment.
You be great to make this translatable using _("Translatable"). Also we're moving away from slice in favor of chart.
To minimize the number of strings to translate you may want to break it into chunks:
_("You don't have the rights to ") + _("create this ") + _("slice")
|
Sorry our linter configuration is picky about As a sidenote (may be out-of-scope for this PR) we need to write a solid test suite around accessibility/security. I'll create an issue for it. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Add permissions checks for save_or_overwrite_slice * Change is_owner to check_ownership * Add translation to chart and dashboard error messages * Appease the python linter by using single quotes
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Add permissions checks for save_or_overwrite_slice * Change is_owner to check_ownership * Add translation to chart and dashboard error messages * Appease the python linter by using single quotes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to resolve issue #3498
saveastoexplorerequestadd_to_dash == existingtoexplorerequestadd_to_dash == newtoexplorerequest