Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard export download #3773

Merged

Conversation

michellethomas
Copy link
Contributor

@graceguo-supercat When using the dashboard exporting functionality in chrome, the popup gets blocked so the download doesn't happen. This fixes the popup getting blocked.

@coveralls
Copy link

coveralls commented Nov 3, 2017

Coverage Status

Coverage remained the same at 71.271% when pulling 31cc03e on michellethomas:fixing_export_dashboards into 7f3edad on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.271% when pulling 31cc03e on michellethomas:fixing_export_dashboards into 7f3edad on apache:master.

@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit aed7c74 into apache:master Nov 4, 2017
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@rjurney
Copy link
Contributor

rjurney commented Apr 30, 2019

Not anymore... as of release--0.31 and I hear 0.29. See #7353.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants