-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): Include CSRF token value in beacon call #30718
Conversation
I see the failed frontend test. I'll fix the existing and create a new one specific to this case a little later today. |
I don't have a working local environment, so I'm using github to run the tests.
It was added because of the typo in the actual code under test
Include tests for csrf in beacon
@rusackas unit tests passed. Ready to go. |
Hold off on this, I'm just discovering that it could actually be an issue in our configuration. Seems by default the
But for some reason ours was defined to be |
Confirming that the issue was actually a misconfiguration on our end. I'll close this PR. |
SUMMARY
Before sending the log beacon call, include the CSRF token if it exists.
TESTING INSTRUCTIONS
POST /superset/log
messages are 200s and not 302s.ADDITIONAL INFORMATION