Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix tip box in "Installing From Scratch" page #24915

Merged
merged 3 commits into from
Aug 8, 2023
Merged

docs: fix tip box in "Installing From Scratch" page #24915

merged 3 commits into from
Aug 8, 2023

Conversation

giuliotal
Copy link
Contributor

SUMMARY

Change tip box formatting so that it is properly closed and link to referred page is added.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

ADDITIONAL INFORMATION

Fixes #24914

@giuliotal giuliotal changed the title doc: fix tip box in "Installing From Scratch" page docs: fix tip box in "Installing From Scratch" page Aug 8, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @giuliotal!

@michael-s-molina michael-s-molina merged commit 81bf2f0 into apache:master Aug 8, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Fix tip box in "Installing From Scratch" page
3 participants